[PATCH] Improve git-update.sh status message

[Tim-Philipp Müller]

On Tue, 2013-05-28 at 23:45 +0100, Krzysztof Konopko wrote:

Hi,

thanks for the patch, but could you please file a bug in bugzilla [1]
and attach it there? That way it won't get lost. Thanks!

Cheers
 -Tim

[1] http://gstreamer.freedesktop.org/bugs/

> By default when the script is about to exit (normally or due to an error),
> it checks whether $ERROR_LOG file exists.  If the log file exists, the
> script prints a "Failures: " message prefix and dumps the log file to the
> output.
> 
> Apparently the log file is always created and if the update/build is
> successful, the script finishes with a bit misleading "Failures: " message.
> 
> An improvement provided with this change lets the log file to be created as
> needed, i.e. if there's an error message to be printed.  If the file
> doesn't exists, the script prints a "Update done" message which clearly
> indicates success.
> ---
>  scripts/git-update.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/git-update.sh b/scripts/git-update.sh
> index 221e1ae..fba0c6e 100755
> --- a/scripts/git-update.sh
> +++ b/scripts/git-update.sh
> @@ -28,7 +28,6 @@ tmp=$tmp/git-update.$(date +%Y%m%d-%H%M-).$RANDOM.$RANDOM.$RANDOM.$$
>  }
>  
>  ERROR_LOG="$tmp/failures.log"
> -touch $ERROR_LOG
>  ERROR_RETURN=255
>  
>  for m in $CORE $MODULES $EXTRA_MODULES; do
> @@ -124,6 +123,7 @@ if test -e $ERROR_LOG;  then
>    echo
>    cat $ERROR_LOG
>  else
> +  echo "Update done"
>    rm -rf "$tmp"
>  fi
>  exit