gst-plugins-gl: gstglcontext_egl: avoid non working EGL confs on rpi/ wayland

Sebastian Dröge slomo at circular-chaos.org
Tue Oct 1 05:07:13 PDT 2013


On Di, 2013-10-01 at 04:53 -0700, Julien Isorce wrote:
> Module: gst-plugins-gl
> Branch: master
> Commit: 9fe682ad2c732214543fc3fc2937f316416083c3
> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-gl/commit/?id=9fe682ad2c732214543fc3fc2937f316416083c3
> 
> Author: Julien Isorce <julien.isorce at collabora.co.uk>
> Date:   Tue Oct  1 11:44:00 2013 +0000
> 
> gstglcontext_egl: avoid non working EGL confs on rpi/wayland
> 
> ---
> 
>  gst-libs/gst/gl/egl/gstglcontext_egl.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/gst-libs/gst/gl/egl/gstglcontext_egl.c b/gst-libs/gst/gl/egl/gstglcontext_egl.c
> index b7edf4b..27d3753 100644
> --- a/gst-libs/gst/gl/egl/gstglcontext_egl.c
> +++ b/gst-libs/gst/gl/egl/gstglcontext_egl.c
> @@ -168,6 +168,15 @@ gst_gl_context_egl_choose_config (GstGLContextEGL * egl,
>      config_attrib[i++] = EGL_OPENGL_ES2_BIT;
>    else
>      config_attrib[i++] = EGL_OPENGL_BIT;
> +#if defined(USE_EGL_RPI) && defined(GST_GL_HAVE_WINDOW_WAYLAND)
> +  /* The configurations r=5 g=6 b=5 seems to be buggy whereas
> +   * it works when using dispmanx directly */

That comment doesn't really explain the change :) Also don't we use an
8888 configuration anyway, and never 565?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20131001/cec8219c/attachment.pgp>


More information about the gstreamer-devel mailing list