android h264 hardware encoding

cee1 fykcee1 at gmail.com
Mon Oct 21 04:49:19 CEST 2013


2013/10/20 Sebastian Dröge <slomo at coaxion.net>:
> How are the template caps of the sinkpad built currently? By iterating
> over the colorformats supported by the encoder, right? Then it should
> indeed by fine and the error should be looked for on a) the code that
> generates the sinkpad template caps, b) in the code from Samsung.
>
> The code you pasted is only for negotiating a correct format with
> downstream, e.g. to negotiate the h264 profile and level.
Well, in base_init(), it will create caps of sink_pad/src_pad from
codec_info, that is the former create_src_caps/create_sink_caps and
now gst_amc_codec_info_to_caps.

In set_format(), the passed in state(GstVideoCodecState, the
input_state) and calculated allowed_caps(negotiated with downstream)
are passed to create_amc_format, which will:
1. Get mime, profile/level from allowed_caps.
2. Get color-format, frame-rate, width and height from state.
3. Get other things like i-frame-interval from properties and calculation.

I think the code should be fine.



-- 
Regards,

- cee1


More information about the gstreamer-devel mailing list