Compile error for Git Master

[Sebastian Dröge]

On Do, 2014-05-08 at 10:32 -0400, Nicolas Dufresne wrote:
> Le mercredi 07 mai 2014 à 22:44 +0200, Peter Maersk-Moller a écrit :
> > Hi.
> > 
> > 
> > 
> > Error preventsGit Master  gst-plugins-bad from compiling. The errors
> > are:
> > 
> > make[5]: Entering directory
> > `/home/stream/Projects/GStreamer/Git/gst-plugins-bad/gst-libs/gst/gl'
> >   CC       libgstgl_1.0_la-gstgldisplay.lo
> > gstgldisplay.c: In function 'gst_gl_display_new':
> > gstgldisplay.c:115:30: error: variable 'platform_choice' set but not
> > used [-Werror=unused-but-set-variable]
> >    const gchar *user_choice, *platform_choice;
> >                               ^
> > cc1: all warnings being treated as errors
> > make[5]: *** [libgstgl_1.0_la-gstgldisplay.lo] Error 1
> > 
> > 
> > If 'GST_GL_HAVE_PLATFORM_EGL' is not defined, then platform_choice is
> > defined and set, but not used which with the configured compiling
> > settings throws an error. If the setting of platform_choice is moved
> > in under the
> > '#if GST_GL_HAVE_PLATFORM_EGL' then the platform_choice is defined,
> > but not used throwing an error. So that must be guarded as well by the
> > 'GST_GL_HAVE_PLATFORM_EGL.
> 
> 
> It's used always if debug traces is enabled. So I suppose you disabled
> debug traces in your build and EGL is the only supported platform.
> 
>   if (!display) {
>     /* subclass returned a NULL window */
>     GST_WARNING ("Could not create display. user specified %s, creating
> dummy",
>         user_choice ? user_choice : "(null)");
> 
> This is a bit tricky/twisted to fix, please file a bug, bugs.gnome.org
> produce GStreamer component gst-plugins-bad.

The problem is that platform_choice is not always used, not user_choice.
Which is fixed by this commit now:
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=5c960069e44d043bd60903046c905873fe63d93f

It will still complain if you build without debugging enabled, but we
don't support -Werror compilation without debugging as it's really just
adding a lot of noise and #ifdefs to the code.

-- 
Sebastian Dröge, Centricular Ltd - http://www.centricular.com
Expertise, Straight from the Source
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 966 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20140508/c6fcc46b/attachment.sig>