gst-plugins-bad - mpegtsmux - duplicate code and memory leak

[Ilya Averyanov]

No memory leak because
in mpegtsmux_reset
 http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/mpegtsmux/mpegtsmux.c#n391
we always free mux->tsmux.
But maybe we need free in mpegtsmux_dispose
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/mpegtsmux/mpegtsmux.c#n429


2015-03-02 1:15 GMT+03:00 Ilya Averyanov <averyanovin at gmail.com>:
> http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/mpegtsmux/mpegtsmux.c#n315
> call
> mux->tsmux = tsmux_new ();
> tsmux_set_write_func (mux->tsmux, new_packet_cb, mux);
>
> in http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/mpegtsmux/mpegtsmux.c#n330
> call
> mpegtsmux_reset
> which also call
>  mux->tsmux = tsmux_new ();
>  tsmux_set_write_func (mux->tsmux, new_packet_cb, mux);
> and rewrite pointer mux->tsmux
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mpegtsmux-Free-tsmux-in-mpegtsmux_dispose.patch
Type: application/octet-stream
Size: 1063 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20150302/d118d207/attachment.obj>