Caps renegotiation with codec_data results in "not-negotiated"

[Sebastian Dröge]

On Sun, 2016-12-11 at 17:09 +0200, Graham Leggett wrote:
> On 23 Nov 2016, at 10:06 AM, Sebastian Dröge <sebastian at centricular.c
> om> wrote:
> 
> > byte-stream h264 has no "codec_data" in the headers, only avc has.
> > The
> > information is in-band in this case.
> 
> Looking at http://www.sharp.fm/0.07.26.578741662-gst-launch.error.dot
> .svg we definitely have some oddness with codec_data being added to
> byte-stream.
> 
> It looks like h264parse is the one that is refusing to negotiate, it
> is receiving a codec_data with a stream-format: byte-stream and then
> refusing to accept it.

h264parse assumes byte-stream if there is codec_data.

> The source of the codec_data is omxh264enc. Looking in
> gst_omx_video_enc_handle_output_frame() in gstomxvideoenc.c I’m not
> seeing anything that checks first whether we are byte-stream or avc
> before adding the codec_data to the caps.

That would be a bug, yes. The codec_data should be in-band for byte-
stream.

-- 
Sebastian Dröge, Centricular Ltd · http://www.centricular.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20161212/3e4ebfe7/attachment.sig>