gst_omx_video_enc_set_format: code should not be reached

[Sebastian Dröge]

On Mo, 2016-02-22 at 22:55 +0100, Peter Maersk-Moller wrote:
> Hi.
> 
> Trying to use omxh264enc (1.2.0 with GStreamer 1.6.3) I see, using
> gst-inspect-1.0 that the module sink capabilities are reported as:
> 
>   video/x-raw
>                   width: [ 1, 2147483647 ]
>                  height: [ 1, 2147483647 ]
>               framerate: [ 0/1, 2147483647/1 ]
> 
> Apparently, it does not set limits for format. However it appear that
> the modules will only accept I420. Using the following pipeline, it
> works.

The template caps are supposed to be configured by the gstomx.conf to
be exactly what *your hardware* supports. Even if the gstomxh264enc.c
code had support for various other formats, it would still depend on
what your hardware can handle in the end.

> gst-launch-1.0 -v videotestsrc is-live=1 ! \
> 'video/x-raw,format=I420' ! queue ! omxh264enc ! fakesink
> 
> However if the format is replaced with ne of the following formats:
> RGB, BGR, ARGB, ABGR, RGBA, BGRA, I get this message:
> 
> ERROR: from element
> /GstPipeline:pipeline0/GstVideoTestSrc:videotestsrc0: Internal data
> flow error.
> Additional debug info:
> gstbasesrc.c(2943): gst_base_src_loop ():
> /GstPipeline:pipeline0/GstVideoTestSrc:videotestsrc0:
> streaming task paused, reason not-negotiated (-4)
> 
> Now if the videoconvert module is add using this pipeline
> 
> 
> gst-launch-1.0 -v videotestsrc is-live=1 ! \
> 'video/x-raw,format=BGRA' ! queue ! omxh264enc ! fakesink
> 
> I get the error message:
> 
> gst_omx_video_enc_set_format: code should not be reached
> 
> Is this a feature or a bug? I would expect that the module at least
> inform, using gst-inspect, that it has limitations wrt. formats. But
> it would be nice if BGRA (and others) could be supported given the
> hefty penalty one has to pay if using videoconvert module on the PI
> platform.

It should probably not run into the assertion but error out cleanly. Do
you want to provide a patch for that? :)

-- 
Sebastian Dröge, Centricular Ltd · http://www.centricular.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20160223/4f9b0ee8/attachment.sig>