Setting overlay parameters on v4l2sink fails

[Nicolas Dufresne]

Le lundi 25 janvier 2016 à 15:08 +0100, Andreas Naumann a écrit :
> Hi Nicolas,
> 
> would this suffice?

Looks good to me. Write this patch for git master, commit it to git and
attach it to be bug on bugzilla.gnome.org (use git format-patch -1 and
attach the file).

Cheers,
Nicolas

> 
> 
> Index: gst1-plugins-good-1.6.0/sys/v4l2/gstv4l2sink.c
> ===================================================================
> --- gst1-plugins-good-1.6.0.orig/sys/v4l2/gstv4l2sink.c	2015-
> 03-05 
> 12:07:44.000000000 +0100
> +++ gst1-plugins-good-1.6.0/sys/v4l2/gstv4l2sink.c	2016-01-25 
> 14:56:12.995743849 +0100
> @@ -250,7 +250,10 @@
>       struct v4l2_format format;
> 
>       memset (&format, 0x00, sizeof (struct v4l2_format));
> -    format.type = V4L2_BUF_TYPE_VIDEO_OVERLAY;
> +    if ( v4l2sink->v4l2object->vcap.capabilities & 
> V4L2_CAP_VIDEO_OUTPUT_OVERLAY )
> +		format.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_OVERLAY;
> +	else
> +		format.type = V4L2_BUF_TYPE_VIDEO_OVERLAY;
> 
>       if (v4l2_ioctl (fd, VIDIOC_G_FMT, &format) < 0) {
>         GST_WARNING_OBJECT (v4l2sink, "VIDIOC_G_FMT failed");
> 
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20160125/5e4de8fd/attachment.sig>