gst-plugins-good: videocrop mark crop properties as mutable in playing state

[Nicolas Dufresne]

Le lundi 23 mai 2016 à 18:17 +0000, Tim Müller a écrit :
> Module: gst-plugins-good
> Branch: master
> Commit: 3d979d4e879f1c18ffa64ecfd9887669eba97220
> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit
> /?id=3d979d4e879f1c18ffa64ecfd9887669eba97220
> 
> Author: Tim-Philipp Müller <tim at centricular.com>
> Date:   Sun May 22 20:14:18 2016 +0100
> 
> videocrop mark crop properties as mutable in playing state
> 

Last time I tested, changing those in playing state lead to a crash or
spurious negotiation error. I had to use a probe in front to safely be
able to change this.

Nicolas

> ---
> 
>  gst/videocrop/gstvideocrop.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/gst/videocrop/gstvideocrop.c
> b/gst/videocrop/gstvideocrop.c
> index 511161e..d9a8f1a 100644
> --- a/gst/videocrop/gstvideocrop.c
> +++ b/gst/videocrop/gstvideocrop.c
> @@ -180,19 +180,23 @@ gst_video_crop_class_init (GstVideoCropClass *
> klass)
>    g_object_class_install_property (gobject_class, PROP_LEFT,
>        g_param_spec_int ("left", "Left",
>            "Pixels to crop at left (-1 to auto-crop)", -1, G_MAXINT,
> 0,
> -          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
> +          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS |
> +          GST_PARAM_MUTABLE_PLAYING));
>    g_object_class_install_property (gobject_class, PROP_RIGHT,
>        g_param_spec_int ("right", "Right",
>            "Pixels to crop at right (-1 to auto-crop)", -1, G_MAXINT,
> 0,
> -          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
> +          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS |
> +          GST_PARAM_MUTABLE_PLAYING));
>    g_object_class_install_property (gobject_class, PROP_TOP,
> -      g_param_spec_int ("top", "Top",
> -          "Pixels to crop at top (-1 to auto-crop)", -1, G_MAXINT,
> 0,
> -          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
> +      g_param_spec_int ("top", "Top", "Pixels to crop at top (-1 to
> auto-crop)",
> +          -1, G_MAXINT, 0,
> +          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS |
> +          GST_PARAM_MUTABLE_PLAYING));
>    g_object_class_install_property (gobject_class, PROP_BOTTOM,
>        g_param_spec_int ("bottom", "Bottom",
>            "Pixels to crop at bottom (-1 to auto-crop)", -1,
> G_MAXINT, 0,
> -          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
> +          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS |
> +          GST_PARAM_MUTABLE_PLAYING));
>  
>    gst_element_class_add_static_pad_template (element_class,
> &sink_template);
>    gst_element_class_add_static_pad_template (element_class,
> &src_template);
> 
> _______________________________________________
> gstreamer-commits mailing list
> gstreamer-commits at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/gstreamer-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20160523/d2320de0/attachment.sig>