[PATCH v2 0/3] gstreamer-imx: add efficient GRAY8/h264 conversion

Philippe Normand phil at base-art.net
Tue Sep 6 13:24:03 UTC 2016


On Tue, 2016-09-06 at 14:52 +0200, phdm at macq.eu wrote:
> From: Philippe De Muyter <phdm at macqel.be>
> 
> Hi Carlos,
> 
> I hope this (gstreamer-devel mailing list) is the right place to send
> patches for gstreamer-imx.

We use Bugzilla for patch reviews but gstreamer-imx not being part of
the official modules you should create a pull request on their Github
repository.

Philippe

> 
> This patch series adds efficient GRAY8/h264 conversion to gstreamer-
> imx,
> by using a constant memory zone populated with the value '128' for
> the
> Cb and Cr planes that are requested by h268, but not provided by
> GRAY8.
> Because of the API of libimxvpuapi, I had to set cb_offset and
> cr_offset
> to the difference between the physical address of the new zone and
> the physical address of the Y plane, which is a hack I admit, but
> this works perfectly.
> 
> In order to free cleanly this zone, I needed to add a 'close' vfunc
> to encoder_base.
> 
> There is also a unrelated new check to allow compilation when
> GST_VIDEO_FORMAT_NV61 is not defined.
> 
> Philippe De Muyter
> 
> v2: move allocation of cbcr_buffer from
> gst_imx_vpu_encoder_h264_set_frame_enc_params to
> gst_imx_vpu_encoder_h264_set_open_params.
> 
> Philippe De Muyter (3):
>   v4l2src: Add GST_VIDEO_FORMAT_NV61 check.
>   vpu/encoder_base: add a 'close' subclass vfunc
>   vpu/encoder_h264: accept GRAY8 on input.
> 
>  src/v4l2src/v4l2src.c  |  2 ++
>  src/vpu/encoder_base.c |  8 ++++++++
>  src/vpu/encoder_base.h |  4 ++++
>  src/vpu/encoder_h264.c | 39 ++++++++++++++++++++++++++++++++++++++-
>  src/vpu/encoder_h264.h |  2 ++
>  5 files changed, 54 insertions(+), 1 deletion(-)
> 


More information about the gstreamer-devel mailing list