[RFC] provide a bin to GstRtspMediaFactory

[Eloi Bail]

Hi all,

We were thinking about the ability to set / get a bin to a
GstRtspMediaFactory.
The use case is to be able to modify an element of the pipeline during a
live RTSP session without renegotiating a RTSP stream.

The modification needs to be compatible with the format provided by the SDP.
In our case it is a video-flip which does not modify the video resolution.

The patches in attachment adds the ability to get/set a bin. They are based
on a old work of Tristan Matthews [1]


We currently see one limitation:

* After all RTSP client disconnected from the RTSP session, we see a
critical issue:

(lt-test-bin:2344): GStreamer-CRITICAL **: gst_ghost_pad_new: assertion
> '!gst_pad_is_linked (target)' failed
>
> (lt-test-bin:2344): GStreamer-CRITICAL **: gst_pad_set_active: assertion
> 'GST_IS_PAD (pad)' failed
>
> (lt-test-bin:2344): GStreamer-CRITICAL **: gst_element_add_pad: assertion
> 'GST_IS_PAD (pad)' failed
>
> ** (lt-test-bin:2344): CRITICAL **: gst_rtsp_stream_new: assertion
> 'GST_IS_PAD (pad)' failed
>
> ** (lt-test-bin:2344): CRITICAL **: gst_rtsp_stream_set_multicast_iface:
> assertion 'GST_IS_RTSP_STREAM (stream)' failed
>
> ** (lt-test-bin:2344): CRITICAL **: gst_rtsp_stream_set_profiles:
> assertion 'GST_IS_RTSP_STREAM (stream)' failed
>
> ** (lt-test-bin:2344): CRITICAL **: gst_rtsp_stream_set_protocols:
> assertion 'GST_IS_RTSP_STREAM (stream)' failed
>

This issue does not occur with test-launch.

Any comments or questions are welcomed !

Eloi

[1]: https://github.com/tmatth/gst-prototypes/tree/master/gstrtspserver
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20171205/f015faac/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-add-test-bin-example.patch
Type: text/x-patch
Size: 4596 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20171205/f015faac/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rtsp-media-factory-add-bin-property.patch
Type: text/x-patch
Size: 7769 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20171205/f015faac/attachment-0003.bin>