GES 1.12, Two bugs (possibly related) with (1) GESEffect volume and (2) layer ordering priority

[Thibault Saunier]

This is correct yes. I just figured that your problem is that you add
an *audio* effect on a *video only* clip.... I tested and that fails
in the way you describe (we should probably be smarter here, but it is
a programming error on your side.

On Thu, Jul 19, 2018 at 7:03 PM David Ing <ding at panopto.com> wrote:
>
> My timeline consists of 3 layers, where each layer has a GESUriClip.
>
> For each of the 3 clips, ...
>
> I created a GESEffect using either
>
> GESEffect* gesEffect = ges_effect_new("volume volume=1.0")
>
> GESEffect* gesEffect = ges_effect_new("volume mute=true")
>
> Then I added the effect to the clip
>
> ges_container_add(reinterpret_cast<GESContainer*>(gesUriClip),  reinterpret_cast<GESTimelineElement*>(gesEffect))
>
> Is this generally the correct way to add effects to clips?  (Sometimes I feel like I'm groping around a dark hallway.)
>
> On Thu, Jul 19, 2018 at 3:53 PM, Thibault Saunier <tsaunier at gnome.org> wrote:
>>
>> > Thibault, your suggestion for #1 worked like a charm.  It fixed both of the problems.
>> >
>> > I have two followup questions.
>> >
>> > This experience has me a little worried.  If GESEffect does not work well for the `volume` plugin, can I expect problems with most of the other plugins?
>>
>> Well, we use it very extensively in Pitivi without (known) problem,
>> how did you use them exactly?
>>
>> > For future reference, I don't know how to save a *.xges file.  Would I use `ges_timeline_save_to_uri` for that?
>>
>> Yes.
>>
>> > On Thu, Jul 19, 2018 at 2:35 PM, Thibault Saunier <saunierthibault at gmail.com> wrote:
>> >>
>> >> Hello,
>> >>
>> >> 1. Setting mute=true means that the source will send silent, which is
>> >> not what you want. Also you do not need an effect to handle the volume
>> >> as there is already a volume element inside sources you can use the
>> >> ges_timeline_element_set_child_property(element, "volume"....)[0]
>> >> method to set it. You can see what properties audio sources expose
>> >> here: https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer-editing-services/html/GESAudioSource.html
>> >>
>> >> 2. Layer with lower priorities are on top of the stack of layers,
>> >> meaning that layer with prio=0 is "the first". Now I am not sure why
>> >> you get that error but it seems to be a NLEObject priority issue.
>> >> Providing a .xges file would help (just save your timeline and paste
>> >> it here if removing the effect doesn't work).
>> >>
>> >> Regards,
>> >>
>> >> Thibault Saunier
>> >>
>> >> [0] https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer-editing-services/html/GESTimelineElement.html#ges-timeline-element-set-child-property
>> >> _______________________________________________
>> >> gstreamer-devel mailing list
>> >> gstreamer-devel at lists.freedesktop.org
>> >> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>> >
>> >
>> > _______________________________________________
>> > gstreamer-devel mailing list
>> > gstreamer-devel at lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>> _______________________________________________
>> gstreamer-devel mailing list
>> gstreamer-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>
>
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel