cerbero: cerbero: Require CC/CXX/AR, fix splitting of empty space

[Nirbheek Chauhan]

On Sat, Jul 21, 2018 at 9:18 AM Nirbheek Chauhan
<nirbheek.chauhan at gmail.com> wrote:
>
> On Sat, Jul 21, 2018 at 8:43 AM Nicolas Dufresne <nicolas at ndufresne.ca> wrote:
> >
> > Le jeudi 19 juillet 2018 à 19:06 +0000, Nirbheek Chauhan a écrit :
> > > Module: cerbero
> > > Branch: master
> > > Commit: 2d871f5312bcaed1207b48cb208b748208946cfd
> > > URL:    http://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=2d87
> > > 1f5312bcaed1207b48cb208b748208946cfd
> > >
> > > Author: Nirbheek Chauhan <nirbheek at centricular.com>
> > > Date:   Fri Jul 20 00:52:25 2018 +0530
> > >
> > > cerbero: Require CC/CXX/AR, fix splitting of empty space
> > >
> > > When a tool is not defined, it should be `[]` not `['']`. Also,
> > > CC/CXX/AR are always defined and needed while cross-compiling, so
> > > require them.
> >
> > They are not always defined, please fix the regressions:
> >
> > https://ci.gstreamer.net/job/cerbero-cross-mingw64/7483/console
> >
>
> I can't reproduce that failure, and it should be impossible:
>
> $ grep CC config/windows.config
> # Default GCC compiler flags
>     os.environ['CC']= '%s%s' % (ccache, cmd('gcc'))
>
> CC/CXX/AR are all defined on all platforms. Also, cross-win32 has
> basically the same configuration, and that passes.
>
> The only thing I can think of is that the CI is not setup correctly.
> Is there some way I can get the contents of localconf.cbc that's
> generated by the CI? The CI runs `gst-ci-scripts` to generate it, but
> I can't find that script anywhere.

I was able to reproduce the problem and I fixed it with:

commit 461803fec5700087ff0e91f6c16444729855b92a
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Sat Jul 21 09:35:32 2018 +0530

    cerbero: Ensure that deleted env vars are restored on return

    Otherwise these variables will be gone for the rest of the build.

    This wasn't caught immediately because it only breaks when you build
    multiple recipes in a single run.