[webrtcbin] Is set-local-description synchronous?

[Rob Agar]

The odd thing is that it was working happily with the /promise/ argument 
missing entirely, but after a rebuild against gstreamer 1.20.2 it 
started crashing...

On 04/05/2022 13:17, Florian Echtler wrote:
> Hello Rob,
>
> based on my (limited) understanding, this is unlikely to work, the 
> offer will be empty in 99% of cases in your example. So you do need to 
> wait for the promise to come back first.
>
> Best, Florian
>
> On 04.05.22 11:45, Rob Agar via gstreamer-devel wrote:
>> Basically is this OK?
>>
>> //setlocaldescription 
>> g_signal_emit_by_name(webrtc,"set-local-description",offer, NULL);
>>
>> //notifylistenertosendoffersignal
>> gchar*description=gst_sdp_message_as_text(offer->sdp);
>> LOG(description)
>> listener->onLocalOffer(description);
>> g_free(description);
>>
>> Or should we be passing a non-null promise argument, and only 
>> proceeding to send the offer when it notifies?
>>
>> cheers
>>
>> Rob
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20220504/c1604b4c/attachment.htm>