<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-CA" link="#0563C1" vlink="purple"> <div class="WordSection1"> Hi Matthew,<o:p></o:p> <o:p> </o:p> Thanks a lot for your reply!<o:p></o:p> <o:p> </o:p> We’d like to elaborate on it a bit more. According to webrtc spec (<a href="https://w3c.github.io/webrtc-pc/#mandatory-to-implement-stats">https://w3c.github.io/webrtc-pc/#mandatory-to-implement-stats</a>), the mandatory fields for "RTCIceCandidatePairStats" include: transportId, localCandidateId, remoteCandidateId, state, nominated, bytesSent, bytesReceived, totalRoundTripTime, currentRoundTripTime<o:p></o:p> <o:p></o:p> However, we find some of the fields not easy to implement:<o:p></o:p> <ol style="margin-top:0cm" start="1" type="1"> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1">state, nominated, totalRoundTripTime, currentRoundTripTime<o:p></o:p></li></ol> These information are all related to STUN connectivity checks, which currently are not exposed in the Libnice public APIs. It would be very difficult to collect these data without modifying Libnice APIs.<o:p></o:p> <ol style="margin-top:0cm" start="2" type="1"> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1">bytesSent, bytesReceived<o:p></o:p></li></ol> These represent the total number of payload bytes sent/received on the candidate pair. We think of some potential approaches:<o:p></o:p> <ol style="margin-top:0cm" start="2" type="1"> <ol style="margin-top:0cm" start="1" type="a"> <li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level2 lfo1">Add buffer probes in dtlssrtpenc and dtlssrtpdemux to calculate the bytes sent/received<o:p></o:p></li><li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level2 lfo1">Collect from srtpenc(<a href="https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/srtp/gstsrtpenc.c#L1205">https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/srtp/gstsrtpenc.c#L1205</a>), dtlsenc(<a href="https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/dtls/gstdtlsenc.c#L519">https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/dtls/gstdtlsenc.c#L519</a>), and dtlssrtpdemux(<a href="https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/dtls/gstdtlssrtpdemux.c#L105">https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/dtls/gstdtlssrtpdemux.c#L105</a>). And we could expose an property in dtlssrtpenc and dtlssrtpdemux for the collected data.<o:p></o:p></li><li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level2 lfo1">Calculate from the bytes sent/received data in RTP stream stats (<a href="https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/webrtc/gstwebrtcstats.c#L91">https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/webrtc/gstwebrtcstats.c#L91</a>). We would also need to gather the data for data-channel because that's not covered in RTP stream stats.<o:p></o:p></li></ol> </ol> Please let us know if there's a better way to do it. <o:p></o:p> <o:p></o:p> We'd like to get more guidance on how to implement these fields. If there's no good approach to do it yet, can we leave them out for now?<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Sherrill<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Matthew Waters <ystreet00@gmail.com> Date: Friday, October 23, 2020 at 2:44 AM To: Discussion of the development of and with GStreamer <gstreamer-devel@lists.freedesktop.org>, "Lin, Sherrill" <lshuying@amazon.com> Cc: comms-media-process <comms-media-process@amazon.com> Subject: RE: [EXTERNAL] Question about implementing WebRTC Stats<o:p></o:p> </div> <div> <o:p> </o:p> </div> Hi, It would certainly be beneficial to Implement the mandatory stats required but it wouldn't quite be a hard rejection if they aren't implemented. It would require a reasonable explanation as to why they aren't implemented for new structures though. Cheers -Matt<o:p></o:p> <div> On 23/10/20 8:00 am, Lin, Sherrill wrote:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Hi there,<o:p></o:p> <o:p></o:p> Our team in Alexa Communications wants to add selected ice candidates information to WebRTC stats. We find that in gstwebrtcstats.c (<a href="https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/webrtc/gstwebrtcstats.c">https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/blob/master/ext/webrtc/gstwebrtcstats.c</a>), RTCIceCandidateStats, RTCIceCandidatePairStats and RTCTransportStats are not constructed yet. We think these three stats are the structures needed for hosting selected ice candidate data, and we are interested in implementing them following the w3.org spec (<a href="https://www.w3.org/TR/webrtc-stats/">https://www.w3.org/TR/webrtc-stats/</a>).<o:p></o:p> <o:p></o:p> However, we notice there’s a list of mandatory fields for implementing each stats structure: <a href="https://w3c.github.io/webrtc-pc/#mandatory-to-implement-stats">https://w3c.github.io/webrtc-pc/#mandatory-to-implement-stats</a>. Does it mean, for Gstreamer community to accept the code changes, we will have to implement all the mandatory fields for all three stats structures as defined in that doc?<o:p></o:p> <o:p></o:p> Thanks,<o:p></o:p> Sherrill<o:p></o:p> <o:p></o:p> <pre>_______________________________________________<o:p></o:p></pre> <pre>gstreamer-devel mailing list<o:p></o:p></pre> <pre><a href="mailto:gstreamer-devel@lists.freedesktop.org">gstreamer-devel@lists.freedesktop.org</a><o:p></o:p></pre> <pre><a href="https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel">https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel</a><o:p></o:p></pre> </blockquote> <o:p></o:p> </div> </body> </html>