<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=gb2312"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">Can you share patch to me to test it on our platform.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">Regards,<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">Bing<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> gstreamer-devel <gstreamer-devel-bounces@lists.freedesktop.org> <b>On Behalf Of </b>Nicolas Dufresne<br> <b>Sent:</b> 2021</span><span style="font-family:SimSun">年</span><span lang="EN-US">2</span><span style="font-family:SimSun">月</span><span lang="EN-US">24</span><span style="font-family:SimSun">日</span><span lang="EN-US"> 21:02<br> <b>To:</b> Discussion of the development of and with GStreamer <gstreamer-devel@lists.freedesktop.org><br> <b>Subject:</b> [EXT] Re: v4l2 video encoder<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p><b><span lang="EN-US" style="color:white;background:darkred">Caution: </span></b><span lang="EN-US" style="color:white;background:darkred">EXT Email </span><span lang="EN-US"><o:p></o:p></span></p> <div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-US"><o:p> </o:p></span></p> <div> <div> <p class="MsoNormal"><span lang="EN-US">Le mer. 24 févr. 2021 04 h 45, Bing Song <<a href="mailto:bing.song@nxp.com">bing.song@nxp.com</a>> a écrit :<o:p></o:p></span></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Hi,<o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Gst-transcoding will use v4l2videodec and v4l2videoenc. The default of v4l2videoenc input is MMAP mode. It cause video frame copy in v4l2videoenc input. How to avoid the video frame buffer copy?<o:p></o:p></span></p> </div> </div> </blockquote> </div> </div> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">This needs to be fixed inside v4l2videoenc class. Currently the import is not using the new try_import calls, so it is unsafe as it does not communicate padding and strides to the driver. I have a partial solution to this that I made last week, I need to cleanup and make an MR.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Now, it's partial as it only validate the very first buffer, it should keep validating in case something changes.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">The next Todo before actually making it try to import by default is to figure out how we will handle copy fallback. We could reset the encoder and reallocate, but this method would not be reversible, and would produce a spurious keyframe (meaning the gops might not always be as requested). We need to decide if that would be good enough, in real app, we do hope we will not have to fallback. The alternative would be to have scratch buffers on the side as backup buffers, but the would use a big chunk of memory.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Meanwhile, one can always track the encoder being added to the pipeline (deep-element-added signal, or state transition message) and set the output-io-mode to dmabuf-import mode, and hope that buffers are properly aligned.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> </div> <div> <div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Regards,<o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Bing<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><span lang="EN-US">_______________________________________________<br> gstreamer-devel mailing list<br> <a href="mailto:gstreamer-devel@lists.freedesktop.org" target="_blank">gstreamer-devel@lists.freedesktop.org</a><br> <a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fgstreamer-devel&data=04%7C01%7Cbing.song%40nxp.com%7C0b317c186722435d0f5d08d8d8c46db1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637497685462573907%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7Sb4ojwM9UAVZOoUnUt8S0zREatlSw%2F80%2Fnx0cLi%2FfQ%3D&reserved=0" target="_blank">https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel</a><o:p></o:p></span></p> </blockquote> </div> </div> </div> </div> </div> </body> </html>