[Gstreamer-openmax] [PATCH] Add GstOmxBaseAudioDec base class
Felipe Contreras
felipe.contreras at gmail.com
Sat Nov 14 04:57:56 PST 2009
On Wed, Nov 4, 2009 at 4:26 AM, Rob Clark <rob at ti.com> wrote:
> Refactor some common functionality, in particular the settings_changed_cb, into an abstract base class.
This is a good idea. I wanted to do this, but never managed to do it
due to lack of time =/
> + if (rate == 0)
> + {
> + /** @todo: this shouldn't happen. */
> + GST_WARNING_OBJECT (omx_base, "Bad samplerate");
> + rate = 44100;
> + }
> + }
This was a hack needed for bellagio's MP3 decoder which I think is not
needed any more. We should get rid of this in the master branch, if
somebody needs it, they should either fix their implementation, or
patch gst-openmax.
--
Felipe Contreras
More information about the Gstreamer-openmax
mailing list