[Gstreamer-openmax] [PATCH] add some debug traces and asserts
Rob Clark
rob at ti.com
Sun Nov 22 21:29:29 PST 2009
On Nov 14, 2009, at 7:08 AM, Felipe Contreras wrote:
>> static GstStateChangeReturn
>> @@ -324,6 +336,8 @@ push_buffer (GstOmxBaseFilter *self,
>> {
>> GstFlowReturn ret;
>>
>> + PRINT_BUFFER (self, buf);
>
> Agh, I hate macros. Do we really want this? If so, can we make this an
> inline function?
well, a macro has the benefit of the trace showing the function name
of where the macro was used, rather than the name of the inline
function..
if it weren't for this, I'd agree that an inline function would be
better
(another case of macro == necessary evil ;-))
BR,
-R
More information about the Gstreamer-openmax
mailing list