[Gstreamer-openmax] [PATCH 1/8] core: call OMX_GetHandle in g_omx_core_new

Felipe Contreras felipe.contreras at nokia.com
Fri Apr 16 07:38:08 PDT 2010


On Mon, Mar 29, 2010 at 03:05:39PM +0200, Rob Clark wrote:
> This way omx_handle is always valid, and can be used in get/set_property
> methods.
> ---

I applied this with some changes; I think when future reorganizations
are made what code can be made static would be obvious.

--- a/omx/gstomx.c
+++ b/omx/gstomx.c
@@ -333,10 +333,6 @@ gstomx_get_component_info (void *core,
     return TRUE;
 }
 
-/* for now, to keep gst out of g_omx.. if later g_omx becomes gstomx
- * then this could be combined with the existing g_omx_core_new()
- * and g_omx_core_init() could be made static/private
- */
 void *
 gstomx_core_new (void *object, GType type)
 {
diff --git a/omx/gstomx.h b/omx/gstomx.h
index 4f07fd6..e646300 100644
--- a/omx/gstomx.h
+++ b/omx/gstomx.h
@@ -33,7 +33,7 @@ GST_DEBUG_CATEGORY_EXTERN (gstomx_util_debug);
 gboolean gstomx_get_component_info (void *core,
                                     GType type);
 
-void * gstomx_core_new (void *object, GType type);
+void *gstomx_core_new (void *object, GType type);
 
 G_END_DECLS
 

-- 
Felipe Contreras




More information about the Gstreamer-openmax mailing list