[Gstreamer-openmax] [PATCH] replace deprecated API

Stefan Kost ensonic at hora-obscura.de
Mon Apr 19 00:28:49 PDT 2010


Felipe Contreras wrote:
> On Mon, Apr 19, 2010 at 10:13 AM, Stefan Kost <ensonic at hora-obscura.de> wrote:
>   
>> It has been deprecated to highlight that we suggest to use the newer
>> one. The old one is still there and the new one is there for quite some
>> time, so there is most probably no need to bump any core requirement.
>>     
>
> Yeah, but that's code-style patronizing. So what if I prefer a C99 style like:
>
> GstElementDetails details = {
> 	.longname = "OpenMAX IL AAC audio decoder",
> 	.klass = "Codec/Decoder/Audio",
> 	.description = "Decodes audio in AAC format with OpenMAX IL",
> 	.author = "Felipe Contreras",
> };
>
> gst_element_class_set_details(element_class, &details);
>
> At some point that won't work? Why?
>
>   

It is causing a extra reloc and pointer copying. What I would like to
see instead is to use GstStructure for plugin and element details. Then
we would have:

gst_element_class_set_info(element_class,...)

this could be either a varargs function that takes the args and/or one that takes the structure. Right now using a non extensible intermediate structure is not so useful.

Stefan






More information about the Gstreamer-openmax mailing list