[Gstreamer-openmax] [PATCH] replace deprecated API

Stefan Kost ensonic at hora-obscura.de
Sat Apr 24 13:31:56 PDT 2010


Am 24.04.2010 12:31, schrieb Felipe Contreras:
> On Fri, Apr 23, 2010 at 9:19 PM, Stefan Kost <ensonic at hora-obscura.de> wrote:
>> Am 23.04.2010 20:05, schrieb Felipe Contreras:
>>> Well, so far I don't agree with the change from GStreamer API, so I
>>> think removing GST_DISABLE_DEPRECATED is the sensible solution.
>>
>> Just apply robs patch and its fine. Setting a struct just for passing the
>> parameters is not very useful. I will also do the extensible variant sooner or
>> later becasue I have a needs for it.
> 
> I _can_ do that, but I also can remove GST_DISABLE_DEPRECATED. Given
> that I see no advantage at all of using
> gst_element_class_set_details_simple(), I don't see why we should use
> it. If a better API is provided at some point, sure, we will switch,
> but in the meantime there's no such thing.
> 

Using the disable_deprecated macros simply helps to do gradual porting towards
newer api. I agree that gst_element_class_set_details_simple() does not bring a
huge speedup normally, but then there is no point in wasting cycles. It
definitely shortes a fully registry rescann, which e.g. happens when you install
a new plugin (e.g. on demand). And as usual several small gains (or wastes) add up.
Anyway do as you prefer, I said what I have to say on this matter.

Stefan




More information about the Gstreamer-openmax mailing list