[Gstreamer-openmax] Repeat Mode of Totem Player

[Rob Clark]

The patch looks basically ok with a minor formatting tweak.. if you
could send it inline with git-send-email[1], it makes it easier to
review.


> diff --git a/omx/gstomx_util.c b/omx/gstomx_util.c
> index 283c32d..3ff88d8 100644
> --- a/omx/gstomx_util.c
> +++ b/omx/gstomx_util.c
> @@ -697,8 +697,17 @@ g_omx_port_flush (GOmxPort *port)
>          OMX_BUFFERHEADERTYPE *omx_buffer;
>          while ((omx_buffer = async_queue_pop_forced (port->queue)))
>          {
> -            omx_buffer->nFilledLen = 0;
> -            g_omx_port_release_buffer (port, omx_buffer);
> +            if(omx_buffer->nFlags & OMX_BUFFERFLAG_EOS)


should have a space between "if" and "("


> +            {
> +                omx_buffer->nFlags = 0;
> +                g_omx_port_push_buffer (port, omx_buffer);
> +                break;
> +            }
> +            else
> +            {
> +               omx_buffer->nFilledLen = 0;
> +               g_omx_port_release_buffer (port, omx_buffer);
> +            }
>          }
>      }
>      else
> 



(I guess that is easy enough to fix when pushing the patch, but Felipe
would have to push the patch)

Also, it's preferred to keep the commit comment at less than 80 columns.

BR,
-R

[1] the following link may be helpful to send patches via gmail account..
I use this when sending patches from behind the firewall

http://nishanthmenon.blogspot.com/2009/05/setting-up-email-forwarding-system-for_26.html


On Aug 23, 2010, at 9:36 PM, Mickey Kim wrote:

> 
> Please find the attached file for patch.<0001-gst-openmax-Fix-repeate-mode-issue-of-totem-player.patch>------------------------------------------------------------------------------
> Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
> Be part of this innovative community and reach millions of netbook users 
> worldwide. Take advantage of special opportunities to increase revenue and 
> speed time-to-market. Join now, and jumpstart your future.
> http://p.sf.net/sfu/intel-atom-d2d_______________________________________________
> Gstreamer-openmax mailing list
> Gstreamer-openmax at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-openmax