[Gstreamer-openmax] [PATCH] add some utility macros to get/set core and port configs/params

[Felipe Contreras]

On Sat, Feb 27, 2010 at 8:24 PM, Rob Clark <rob at ti.com> wrote:
> btw, I'm thinking about this one again..
>
> how about, in case of setting all params:
>
>   OMX_AUDIO_PARAM_PCMMODETYPE param;
>
>   G_OMX_INIT_PARAM (param);

I think it should be:

G_OMX_INIT_PARAM (OMX_AUDIO_PARAM_PCMMODETYPE, param);

>   ...  set params ...
>
>   G_OMX_PORT_SET_PARAM (port, OMX_IndexParamAudioPcm, &param);

I don't see a big difference to:

param.nPortIndex = 1;
OMX_SetParameter(omx_base->gomx->omx_handle, OMX_IndexParamAudioPcm, &param);

> or in case where you just want to set a few params:
>
>   OMX_AUDIO_PARAM_PCMMODETYPE param;

You forgot the init I guess.

>   G_OMX_PORT_GET_PARAM (port, OMX_IndexParamAudioPcm, &param);
>
>   ...  set params ...
>
>   G_OMX_PORT_SET_PARAM (port, OMX_IndexParamAudioPcm, &param);

Again, I don't see a big difference to:

param.nPortIndex = 1;
OMX_GetParameter(omx_base->gomx->omx_handle, OMX_IndexParamAudioPcm, &param);

... set params ...

OMX_SetParameter(omx_base->gomx->omx_handle, OMX_IndexParamAudioPcm, &param);

Cheers.

-- 
Felipe Contreras