[Gstreamer-openmax] [PATCH 3/5] Reorganize {library, component}-name assigns

[Clark, Rob]

On Mar 6, 2010, at 12:25 PM, Clark, Rob wrote:

> 
> On Mar 3, 2010, at 4:51 PM, Felipe Contreras wrote:
> 
>> #endif /* GSTOMX_H */
>> diff --git a/omx/gstomx_base_filter.c b/omx/gstomx_base_filter.c
>> index 626f979..01ca10a 100644
>> --- a/omx/gstomx_base_filter.c
>> +++ b/omx/gstomx_base_filter.c
>> @@ -898,6 +898,7 @@ type_instance_init (GTypeInstance *instance,
>>    {
>>        GOmxCore *gomx;
>>        self->gomx = gomx = g_omx_core_new (self);
>> +        gstomx_get_component_info (gomx, G_TYPE_FROM_CLASS (g_class));
>>    }
>> 
> 
> Any reason not to combine g_omx_core_new() and gomx_get_component_info()?
> 


ahh, I get it.. you try to keep the "g_omx" stuff independent of the "gst" stuff..

I guess it is a topic for a different patch, but any objection to lifting this restriction?  I think there is more stuff (such as copying between gst buffers and omx buffers, and handling the share_buffer cases) which could be refactored from the base classes into the utility classes if this separation is lifted.

(If you want to keep the separation.. perhaps we could have GstOmxCore and GstOmxPort subclasses of GOmxCore and GOmxPort.. but that does seem a bit like overkill.)


BR,
-R