[Gstreamer-openmax] [PATCH 1/2] use G_PARAM_STATIC_STRINGS

[Clark, Rob]

On Mar 8, 2010, at 9:36 AM, Felipe Contreras wrote:

> On Sat, Mar 06, 2010 at 10:03:57PM +0100, Rob Clark wrote:
>> as suggested by Stefan Kost
>> ---
> 
> This patch doesn't apply, and it's weird because it says 1/2, but I
> don't see the 0/2 patch.

It should apply on top of your 'remove unused set_property()' patch..  or at least that is the theory.

I made the patch on top of your patches which had not been committed yet, because I figured they would be committed soon, and that would be easier than rebasing..  Have a look at:

  http://gitorious.org/robclark-gstreamer/gst-openmax/commits/patches-1c

to see the order of patches

BR,
-R


> 
>> --- a/omx/gstomx_base_filter.c
>> +++ b/omx/gstomx_base_filter.c
>> @@ -260,17 +260,17 @@ type_class_init (gpointer g_class,
>>         g_object_class_install_property (gobject_class, ARG_COMPONENT_NAME,
>>                                          g_param_spec_string ("component-name", "Component name",
>>                                                               "Name of the OpenMAX IL component to use",
>> -                                                              NULL, G_PARAM_READABLE));
>> +                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
>> 
>>         g_object_class_install_property (gobject_class, ARG_LIBRARY_NAME,
>>                                          g_param_spec_string ("library-name", "Library name",
>>                                                               "Name of the OpenMAX IL implementation library to use",
>> -                                                              NULL, G_PARAM_READABLE));
>> +                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
>> 
>>         g_object_class_install_property (gobject_class, ARG_USE_TIMESTAMPS,
>>                                          g_param_spec_boolean ("use-timestamps", "Use timestamps",
>>                                                                "Whether or not to use timestamps",
>> -                                                               TRUE, G_PARAM_READWRITE));
>> +                                                               TRUE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
>>     }
>> }
>> 
> 
> 
> -- 
> Felipe Contreras