hal ChangeLog,1.140,1.141

David Zeuthen david at pdx.freedesktop.org
Tue May 25 10:15:43 PDT 2004


Update of /cvs/hal/hal
In directory pdx:/tmp/cvs-serv18027

Modified Files:
	ChangeLog 
Log Message:
2004-05-25  David Zeuthen  <david at fubar.dk>

	* hald/linux/block_class_device.c (read_etc_mtab): hal doesn't
	close the filedescriptor when it /etc/mtab wasn't changed of the
	fstat failed. Also when closing a file stream opened with fdopen,
	the original fd is also closed (the fdopen function doesn't dup
	the fd). So the close after fclose is wrong. Patch from Sjoerd
	Simons <sjoerd at luon.net>.
	(detect_fs): When fs detection fails the volume_id struct wasn't
	closed, causing a mem and fd leak. And as a side effect, causing
	me to be unable to open my cd writer with the eject button when
	there was a blank cd inside :). Patch from Sjoerd Simons
	<sjoerd at luon.net>.



Index: ChangeLog
===================================================================
RCS file: /cvs/hal/hal/ChangeLog,v
retrieving revision 1.140
retrieving revision 1.141
diff -u -d -r1.140 -r1.141
--- a/ChangeLog	18 May 2004 21:14:45 -0000	1.140
+++ b/ChangeLog	25 May 2004 17:15:41 -0000	1.141
@@ -1,3 +1,17 @@
+2004-05-25  David Zeuthen  <david at fubar.dk>
+
+	* hald/linux/block_class_device.c (read_etc_mtab): hal doesn't
+	close the filedescriptor when it /etc/mtab wasn't changed of the
+	fstat failed. Also when closing a file stream opened with fdopen,
+	the original fd is also closed (the fdopen function doesn't dup
+	the fd). So the close after fclose is wrong. Patch from Sjoerd
+	Simons <sjoerd at luon.net>.
+	(detect_fs): When fs detection fails the volume_id struct wasn't
+	closed, causing a mem and fd leak. And as a side effect, causing
+	me to be unable to open my cd writer with the eject button when
+	there was a blank cd inside :). Patch from Sjoerd Simons
+	<sjoerd at luon.net>.
+
 2004-05-18  Joe shaw  <joeshaw at novell.com>
 
 	* tools/callouts/fstab-update.sh: Use /media as long as it's there





More information about the hal-commit mailing list