hal ChangeLog,1.407,1.408 configure.in,1.65,1.66

David Zeuthen david at freedesktop.org
Tue Feb 8 13:37:49 PST 2005


Update of /cvs/hal/hal
In directory gabe:/tmp/cvs-serv13543

Modified Files:
	ChangeLog configure.in 
Log Message:
2005-02-08  David Zeuthen  <davidz at redhat.com>

	Patch from Sjoerd Simons <sjoerd at luon.net>. 
	
	Since i seem to be in an extreme mood anyway, attached it is a
	patch that will make hal always drop permissions to non-root. Also
	it removes keeping the net admin capability as it's not being used
	anymore.

	I think it's the right way to do things. There should be no reason
	to run hald as root ever and forcing it from the start of the
	development cycle is a good way of ensuring that :)

	It would also be nice to have the addons that need to start out as
	root (like the ups one) drop permission as soon as possible (one
	can never be too sure)... Probably a utility function would be
	nice for that, but i don't know where to place it (as the addons
	and probers live in different dirs)

	Slightly mangled by myself to remove libcap dep and introduce
	the --retain-privileges option.

	* configure.in: Don't require libcap

	* hald/Makefile.am (hald_LDADD): Don't link with libcap

	* hald/run-hald.sh: Use new --retain-privileges option since this
	is the development runscript

	* hald/hald.c (usage): Remove option --drop-privileges and introduce
	new option --retain-privileges
	(drop_privileges): Just drop to uid/gid of specified haldaemon user
	and group. Don't use libcap anymore.
	(main): Enforce new --retain-privileges option since it's useful for
	development



Index: ChangeLog
===================================================================
RCS file: /cvs/hal/hal/ChangeLog,v
retrieving revision 1.407
retrieving revision 1.408
diff -u -d -r1.407 -r1.408
--- ChangeLog	8 Feb 2005 21:17:37 -0000	1.407
+++ ChangeLog	8 Feb 2005 21:37:47 -0000	1.408
@@ -1,5 +1,41 @@
 2005-02-08  David Zeuthen  <davidz at redhat.com>
 
+	Patch from Sjoerd Simons <sjoerd at luon.net>. 
+	
+	Since i seem to be in an extreme mood anyway, attached it is a
+	patch that will make hal always drop permissions to non-root. Also
+	it removes keeping the net admin capability as it's not being used
+	anymore.
+
+	I think it's the right way to do things. There should be no reason
+	to run hald as root ever and forcing it from the start of the
+	development cycle is a good way of ensuring that :)
+
+	It would also be nice to have the addons that need to start out as
+	root (like the ups one) drop permission as soon as possible (one
+	can never be too sure)... Probably a utility function would be
+	nice for that, but i don't know where to place it (as the addons
+	and probers live in different dirs)
+
+	Slightly mangled by myself to remove libcap dep and introduce
+	the --retain-privileges option.
+
+	* configure.in: Don't require libcap
+
+	* hald/Makefile.am (hald_LDADD): Don't link with libcap
+
+	* hald/run-hald.sh: Use new --retain-privileges option since this
+	is the development runscript
+
+	* hald/hald.c (usage): Remove option --drop-privileges and introduce
+	new option --retain-privileges
+	(drop_privileges): Just drop to uid/gid of specified haldaemon user
+	and group. Don't use libcap anymore.
+	(main): Enforce new --retain-privileges option since it's useful for
+	development
+
+2005-02-08  David Zeuthen  <davidz at redhat.com>
+
 	* hald/linux2/osspec.c: Do not care about link detection, NM and other
 	tools are going to do this on their own now.
 	(link_detection_handle_message): Remove

Index: configure.in
===================================================================
RCS file: /cvs/hal/hal/configure.in,v
retrieving revision 1.65
retrieving revision 1.66
diff -u -d -r1.65 -r1.66
--- configure.in	7 Feb 2005 21:24:16 -0000	1.65
+++ configure.in	8 Feb 2005 21:37:47 -0000	1.66
@@ -190,8 +190,6 @@
   fi
 fi
 
-AC_CHECK_HEADERS([sys/capability.h],, [AC_MSG_ERROR([Please install libcap and the libcap development package])])
-
 dbus_module="dbus-1 >= 0.20"
 pkg_modules="glib-2.0 >= 2.2.2, gobject-2.0 >= 2.2.2, dbus-glib-1 >= 0.20, $dbus_module"
 PKG_CHECK_MODULES(PACKAGE, [$pkg_modules])




More information about the hal-commit mailing list