hal: Branch 'origin'

Artem Kachitchkine artem at kemper.freedesktop.org
Mon Nov 6 11:55:43 PST 2006


 hald/hald_dbus.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

New commits:
diff-tree a56a15b90177734c70a8b03d961a7bcabdea2af8 (from 4b6eebfadb9e4166dd23632c0a381705d4044d0b)
Author: John (J5) Palmieri <johnp at redhat.com>
Date:   Mon Nov 6 11:48:55 2006 -0500

    use g_slist_remove_link instead of g_slist_remove
    
    Data would be freed and then g_slist_remove would be called on the
    link which would leave the link in the list, any subsequent iteration
    over the list would cause us to access freed memory.

diff --git a/hald/hald_dbus.c b/hald/hald_dbus.c
index 32b5503..7b40903 100644
--- a/hald/hald_dbus.c
+++ b/hald/hald_dbus.c
@@ -3976,7 +3976,7 @@ local_server_message_handler (DBusConnec
 				g_free (hih->introspection_xml);
 				g_free (hih->udi);
 				g_free (hih);
-				helper_interface_handlers = g_slist_remove (helper_interface_handlers, i);
+				helper_interface_handlers = g_slist_remove_link (helper_interface_handlers, i);
 			}
 		}
 


More information about the hal-commit mailing list