hal: Branch 'master'
David Zeuthen
david at kemper.freedesktop.org
Wed Jan 10 13:16:41 PST 2007
tools/linux/hal-system-lcd-get-brightness-linux | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
New commits:
diff-tree 5f7de8756eb51d4418c6304f8be0b2c1d41f2a20 (from a785b60d84d1799aed04462e1d1517e4a4c8a446)
Author: Martin Pitt <martin.pitt at ubuntu.com>
Date: Wed Jan 10 16:16:36 2007 -0500
fix bashism in tools/linux/hal-system-lcd-get-brightness-linux
In [1] we got a report that LCD brightness setting does not work on
Sony Vaio laptops. This is due to the 'let = ...' syntax which is a
bashism, but the script has a /bin/sh hashbang.
I replaced the let by its POSIX counterpart.
Thanks,
Martin
[1] https://launchpad.net/ubuntu/+source/hal/+bug/68617
diff --git a/tools/linux/hal-system-lcd-get-brightness-linux b/tools/linux/hal-system-lcd-get-brightness-linux
index 477a22d..673a41e 100755
--- a/tools/linux/hal-system-lcd-get-brightness-linux
+++ b/tools/linux/hal-system-lcd-get-brightness-linux
@@ -52,7 +52,7 @@ elif [ "$HAL_PROP_LAPTOP_PANEL_ACCESS_ME
# cat /proc/acpi/sony/brightness
# 5
value="`cat $HAL_PROP_LINUX_ACPI_PATH`"
- let "value = ${value} - 1"
+ value=$(($value-1))
elif [ "$HAL_PROP_LAPTOP_PANEL_ACCESS_METHOD" = "omnibook" ]; then
# cat /proc/omnibook/lcd
# LCD brightness: 7
More information about the hal-commit
mailing list