PolicyKit: Branch 'master' - 3 commits

Miloslav Trmac mitr at kemper.freedesktop.org
Tue May 7 16:15:07 PDT 2013


 src/polkitagent/polkitagenthelper-pam.c    |    1 +
 src/polkitbackend/polkitbackendauthority.c |    1 -
 src/programs/pkaction.c                    |    5 -----
 3 files changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 8d8a6213c6a8882dc1b51a2030713914c75d6fb9
Author: Miloslav Trmač <mitr at redhat.com>
Date:   Tue May 7 22:32:12 2013 +0200

    Remove an unused va_start
    
    https://bugs.freedesktop.org/show_bug.cgi?id=64336

diff --git a/src/polkitbackend/polkitbackendauthority.c b/src/polkitbackend/polkitbackendauthority.c
index 91ece26..601a974 100644
--- a/src/polkitbackend/polkitbackendauthority.c
+++ b/src/polkitbackend/polkitbackendauthority.c
@@ -1472,7 +1472,6 @@ polkit_backend_authority_log (PolkitBackendAuthority *authority,
   message = g_strdup_vprintf (format, var_args);
   va_end (var_args);
 
-  va_start (var_args, format);
   syslog (LOG_NOTICE, "%s", message);
 
   g_get_current_time (&now);
commit d7b6ab40b586c255c49aba22f558eb6602c88b1e
Author: Miloslav Trmač <mitr at redhat.com>
Date:   Tue May 7 22:30:25 2013 +0200

    Fix a memory leak
    
    https://bugs.freedesktop.org/show_bug.cgi?id=64336

diff --git a/src/polkitagent/polkitagenthelper-pam.c b/src/polkitagent/polkitagenthelper-pam.c
index 7af5321..292abbe 100644
--- a/src/polkitagent/polkitagenthelper-pam.c
+++ b/src/polkitagent/polkitagenthelper-pam.c
@@ -321,6 +321,7 @@ error:
       }
     }
   memset (aresp, 0, n * sizeof *aresp);
+  free (aresp);
   *resp = NULL;
   return PAM_CONV_ERR;
 }
commit c98ceb5347653981eee2e7d670312f0a97da52d3
Author: Miloslav Trmač <mitr at redhat.com>
Date:   Tue May 7 22:26:41 2013 +0200

    Drop unused variable
    
    https://bugs.freedesktop.org/show_bug.cgi?id=64336

diff --git a/src/programs/pkaction.c b/src/programs/pkaction.c
index 2d8c90d..00b2c57 100644
--- a/src/programs/pkaction.c
+++ b/src/programs/pkaction.c
@@ -113,13 +113,11 @@ main (int argc, char *argv[])
   PolkitAuthority *authority;
   GList *l;
   GList *actions;
-  PolkitActionDescription *description;
   GError *error;
 
   action_id = NULL;
   authority = NULL;
   actions = NULL;
-  description = NULL;
   ret = 1;
 
   g_type_init ();
@@ -226,9 +224,6 @@ main (int argc, char *argv[])
   g_list_foreach (actions, (GFunc) g_object_unref, NULL);
   g_list_free (actions);
 
-  if (description != NULL)
-    g_object_unref (description);
-
   g_free (action_id);
 
   if (authority != NULL)


More information about the hal-commit mailing list