[patch] more frequent mtab checking
David Zeuthen
david at fubar.dk
Fri Apr 30 12:24:06 PDT 2004
On Fri, 2004-04-30 at 20:41, Joe Shaw wrote:
> Hi,
>
> All the changes to make the block device and udev stuff asynchronous
> broke the checks on /etc/mtab to add the block.fstype and
> block.mount_point properties. This is because detection_done is called
> well before the udev info about the device nodes comes in.
>
Ah, nice catch.
> The attached patch changes it to be called in the
> block_class_pre_process() function instead. This means more frequent
> checks on /etc/mtab, but in reality I don't think it's a big deal.
>
I agree. It looks good.
> It does call into question the usefulness of detection_done, though.
>
Yeah, we should remove this; as I wrote earlier it was kind of broken of
me to make a distinction between probing and hotplug in the first place.
Cheers,
David
_______________________________________________
hal mailing list
hal at freedesktop.org
http://freedesktop.org/mailman/listinfo/hal
More information about the Hal
mailing list