little fstype detection problems

[Kay Sievers]

On Sat, 2004-08-21 at 16:39 +0200, Sjoerd Simons wrote:
> Hi,
>   
>   With hal 0.2.97 my root partition was suddenly detected as msdos partition
>   map. After some research it looks like there is an empty dos part. map on it
>   and ofcourse an ext3 filesystem. The following shows the part. map
> 
>   #  head -c 512 /dev/sda1| od -A x -t x1 |  tail -n 4 
>   0001b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   *
>   0001f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 55 aa
>   000200
>   
>   Easily fixed ofcourse by placing the dos part. map probe at the end
>   (hal-misdetect.patch).

Fine. Can you test this one? Here we don't return a partmap if all 4
partitions are empty, as this is pretty useless and we can't be sure,
what we're on.

Yeah, good point, we should move it down to the end, as you did in your
patch, but an empty table should not be recognized as anything.

Thanks a lot,
Kay
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-msdospartmap-01.patch
Type: text/x-patch
Size: 814 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20040821/c586da5b/hal-msdospartmap-01.bin
-------------- next part --------------
_______________________________________________
hal mailing list
hal at freedesktop.org
http://freedesktop.org/mailman/listinfo/hal