little fstype detection problems

Kay Sievers kay.sievers at vrfy.org
Sat Aug 21 10:24:58 PDT 2004


On Sat, 2004-08-21 at 19:04 +0200, Sjoerd Simons wrote:
> On Sat, Aug 21, 2004 at 05:12:57PM +0200, Kay Sievers wrote:
> > Fine. Can you test this one? Here we don't return a partmap if all 4
> > partitions are empty, as this is pretty useless and we can't be sure,
> > what we're on.
> 
> Works fine. 
>   
> > Yeah, good point, we should move it down to the end, as you did in your
> > patch, but an empty table should not be recognized as anything.
> 
> An empty msdos partition table could be a new fresh unpartitioned disk or 
> something. Do we want to handle that case ?

Hmm, 2 bytes in the first sector of a disk and a lot of zero's is not
really a partition map or something with a meaning. To use the disk you
need to _partition_ it. We better don't recognize anything, I think.

Kay

_______________________________________________
hal mailing list
hal at freedesktop.org
http://freedesktop.org/mailman/listinfo/hal



More information about the Hal mailing list