Patch for FDI schema

David Zeuthen david at fubar.dk
Mon Nov 8 14:58:52 PST 2004


On Fri, 2004-11-05 at 18:25 -0500, Dave Malcolm wrote:
> Attached is a patch to the DTD and RELAX NG schema for FDI files, which
> makes all of the current FDI files in CVS validate.
> 

Hey, thanks for doing this,

> FWIW the storage-policy.fdi file seemed to be the one that required the
> most extension to the existing schema.
> 
> I refactored the content model of <merge> out so that it's now shared by
> both <merge> and <append> elements (in the rng file, at least) - they
> have identical content models; in particular, both can have a
> "copy_property" type of key.  Is all of this sane?
> 

Yeah, two small things I caught - should be easy to fix (but I don't
grok XML as good as you do!)

> +    compare_lt        CDATA #IMPLIED

Should probably also list compare_le, compare_gt and compare_ge.


> +                               <attribute name="compare_lt">
> +                                       <data type="long"/>
> +                               </attribute>

Actually, compare_* applies to all four data types:

 int
 string
 double
 uint64
 bool

with the usual semantics (e.g. lexicographical ordering on strings;
false is before true etc.); there is no long data type.

> It'd be nice if someone could run the RELAX NG schema through some kind
> of documentation-generator for going into the HAL spec.
> 
> Also attached are a couple of crappy shell scripts I've been using for
> checking validation - though perhaps this sort of checking should be
> integrated into the build framework? (on "make distcheck", perhaps?)
> 

That would be awesome; I will do this for the updated patch.

Thanks,
Dave


_______________________________________________
hal mailing list
hal at freedesktop.org
http://freedesktop.org/mailman/listinfo/hal



More information about the Hal mailing list