VolumeUnmountForced symlink problem

[David Zeuthen]

On Thu, 2005-04-28 at 08:52 +1000, Rohan McGovern wrote:
> On Thu, 28 Apr 2005 07:43, David Zeuthen wrote:
> > On Tue, 2005-04-26 at 15:25 +1000, Rohan McGovern wrote:
> > > Hi all,
> ...
> > > Surely the behaviour should be consistent for both symlinked and real
> > > device node mounts?
> >
> > Yeah, it seems odd that the kernel does this. I have no idea why though,
> > sorry. All that hal does is a 'umount -l /dev/hdc', can you reproduce
> > this without hal in the picture?
> >
> Without HAL, the disc must always be unmounted manually...
> 
> I guess the issue is or may be that HAL calls umount on /dev/hdc, and /dev/hdc 
> will not be in /etc/mtab or /proc/mounts if the drive was mounted with a 
> symlink like /dev/cdrom.  So maybe it would make more sense to call umount
> with the mount point, which will always be present?  Looking at the code, it
> seems like the change should be as simple as the following:

Looks good, I've committed this. Thanks.

Cheers,
David


_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal