[PATCH] fix battery keys if battery is full charged

Danny Kukawka danny.kukawka at web.de
Thu Aug 11 04:14:18 PDT 2005


On Thursday 11 August 2005 09:15, Danny Kukawka wrote:
> On Thursday 11 August 2005 01:39, David Zeuthen wrote:
[...]
> > I think we should just set these to 0 instead of removing them.
> > Reasoning is that the current is really zero (no energy is flowing),
> > plus it'll make client code much easier, don't you think?
>
> O.k. I prefer to provide only keys for things we know, but to set them to a
> default value if the related entry in /proc/acpi/battery/*/{info,state} is
> unknown is also o.k. for me. But I would propose to set such keys to -1 to
> know that the real values are currently unknown. What you think?
>
> I'll rework the patch.

Here the new version of the patch. Now the unknow keys are set to -1.

Cheers,
Danny

 acpi.c |   37 +++++++++++++++++++++++--------------
 1 files changed, 23 insertions(+), 14 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-fix-key_if_battery_isfull_v2.diff
Type: text/x-diff
Size: 2946 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20050811/45a130cc/hal-fix-key_if_battery_isfull_v2.bin
-------------- next part --------------
_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal


More information about the Hal mailing list