[PATCH] fix calculation of battery.charge_level.last_full

Richard Hughes hughsient at gmail.com
Sun Aug 14 14:59:28 PDT 2005


On Wed, 2005-08-10 at 19:05 +0200, Danny Kukawka wrote:
> Hi,
> 
> this is a patch to fix the inaccurate calculation of 
> battery.charge_level.last_full (patch base on my ACPI patch before).
> 
> We should normalise battery.reporting.last_full with voltage_current instead 
> of voltage_design because battery.charge_level.last_full is a changing and 
> not a static value like voltage_design, which is a "marketing assurance".

Eigh? I'm not sure I follow this one.

Surely last_full has to multiplied with the design voltage, rather than
the current voltage to get the correct charge reading. If I understand
correctly, now the last full charge value depends on the current voltage
of the battery - which I think is wrong.

Thanks,

Richard.

_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal




More information about the Hal mailing list