Policy for fdi files?

David Zeuthen david at fubar.dk
Thu Aug 18 11:08:24 PDT 2005


On Thu, 2005-08-18 at 11:52 +0200, Pierre Ossman wrote:
> > I noticed that there's a 10-usb-music-players.fdi aswell. I'll make a
> > patch for that one and send it here.

Excellent. Thanks.

> Here's a patch for that file instead. It includes the functionality of
> the previous fdi so you can ignore that.

I've committed this to CVS. Thanks.

> 
> I found it a bit messy in 10-usb-music-players.fdi though.
> 'portable_audio_player' is sometimes set as capability, sometimes as a
> category, sometimes both and sometimes none. Structure people! :)
> 
> From my point of view all of these devices should have the capability
> 'portable_audio_player'. Those who are a disk drive with the extra
> feature of playing stuff should probably keep 'storage' as category. The
> rest should have 'portable_audio_player'.
> 
> I can fix a patch that cleans this up if this seems ok with you.

Would be awesome. Thanks.

Cheers,
David




More information about the hal mailing list