[PATCH] fix 10-usb-pda.fdi hotsync interface

[Danny Kukawka]

On Monday 22 August 2005 03:05, David Zeuthen wrote:
> On Sat, 2005-08-20 at 19:46 +0200, Danny Kukawka wrote:
> > Hi,
> >
> > this is a patch to fix problems with hotsync interface on USB Palm PDAs.
> > There are several devices which have their hotsync interface not on
> > serial.port 1 but on serial.port 0. Unfortunately to many different
> > devices (30) handled by the visor kernel driver to know which exactly use
> > which port.
> >
> > I added for all, not handled by special cases, Palm PDAs also port 0 as
> > hotsync port to be sure that there is at least one correct port.
> >
> > If someone should have thereby problems, he should add a special match
> > like for Sony Clie 3.5 in the fdi file.
> >
> > Please review.
>
> I'm thinking that maybe this patch makes the section for Sony Clie 3.5
> devices (the one where we match on vid/pid=0x054c/0x0038) redundant?

I don't think so. This is a case where it is alway port 0. And the generally 
rule should not match in this case because of:
<match key="pda.platform" exists="false">

> Otherwise it looks good, thanks.. (though it would be nice if the kernel
> drivers (visor and friends) would export this via sysfs).

I commit the patch (and would also merge cases where we know which port is the 
correct in the future).

Cheers,

Danny