[PATCH] fix for non utf8 valid volume labels

[Danny Kukawka]

On Thursday 25 August 2005 21:49, Kay Sievers wrote:
> On Thu, Aug 25, 2005 at 03:23:03PM -0400, David Zeuthen wrote:
> > On Thu, 2005-08-25 at 20:37 +0200, Danny Kukawka wrote:
> > > Hi,
> > >
> > > this is a patch to fix problems with non utf8 valid volume labels. Now
> > > we check if the volume label is valid and if not we replace the invalid
> > > characters with '?'.
> > >
> > > The reason: D-BUS accept only utf8 valid strings. If the string is
> > > invalid the volume won't be added to HAL. (see:
> > > https://bugzilla.novell.com/show_bug.cgi?id=105445)
> > >
> > > Please review for next release (0.5.4).
> >
> > Looks good to me. Go ahead.
>
> Looks to me like empty labels will set a empty info.product.

You are right. My mistake. Attached new version. I commit this to cvs.

Thanks and Cheers,

Danny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-fix-invalid_utf8_volume_label_fixProduct.diff
Type: text/x-diff
Size: 3252 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20050825/74824c3b/hal-fix-invalid_utf8_volume_label_fixProduct.bin