ACPI "special" button device, and Toshiba specific bits

[David Zeuthen]

On Tue, 2005-11-29 at 20:05 +0000, Richard Hughes wrote:
> Here are three patches to add the start of generic "special" ACPI button
> support.
> 
> The first patch just adds a blank Virtual Input device for all ACPI
> machines:
> 
> udi = '/org/freedesktop/Hal/devices/acpi_uinput'
>   info.udi = '/org/freedesktop/Hal/devices/acpi_uinput'  (string)
>   info.addons = {'hald-addon-acpi-buttons-toshiba'} (string list)
>   linux.hotplug_type = 4  (0x4)  (int)
>   info.capabilities = {'virtualinput'} (string list)
>   info.category = 'virtualinput'  (string)
>   info.product = 'Virtual Input Device'  (string)
>   info.parent = '/org/freedesktop/Hal/devices/computer'  (string)
>   linux.acpi_type = 4  (0x4)  (int)
>   linux.acpi_path = '/dev/uinput'  (string)

Some questions:

 1. why is this device object necessary to expose? What is the purpose
    of it?

 2. Also, why don't you just make the toshiba addon create the device
    objects you need? 

 3. Finally, why does the mapping from e.g. "Satellite Pro A10" to what
    keycodes does what have to be configurable in an .fdi file? Why
    don't you just hardcode that in the toshiba addon? It's not like
    it's likely to change, right?

Cheers,
David