detecting hibernation capability

[Richard Hughes]

On Thu, 2005-12-01 at 11:48 -0500, David Zeuthen wrote:
> On Wed, 2005-11-30 at 17:16 +0000, Richard Hughes wrote:
> > Thanks Joe. New patch attached.
> 
> Thanks, looks correct, only a few style comments:
> 
> +       if (!fp) {
> 
> I know many people do this, but, really, fp is not a boolean, it's a
> pointer and you want to test whether it's NULL so do use (fp == NULL)
> instead. Ditto use (poweroptions != NULL). Be explicit
> 
> +               return;
> 
> Please use the "goto out" pattern for error handling. Also, ideally you
> should use
> 
>   void *foo;
> 
>   foo = NULL;
> 
> instead of
> 
>  void *foo = NULL;

Sure, how about the attached?

Richard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-can_hibernate3.patch
Type: text/x-patch
Size: 5065 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20051201/b4206bdd/hal-can_hibernate3-0001.bin