[tao@debian.org: File descriptor leak prevents eject]

[Sjoerd Simons]

Hi,
  
  I've got the bugreport below with patch in the debian bts. Forwarding it here
  because the reporter didn't know if it was already sent upstream.

----- Forwarded message from David Weinehall <tao at debian.org> -----

Date: Thu, 30 Dec 2004 01:13:30 +0100
From: David Weinehall <tao at debian.org>
Subject: File descriptor leak prevents eject
To: submit at bugs.debian.org
User-Agent: Mutt/1.4.1i

Package: hal
Version: 0.4.2-5
Severity: important
Tags: patch

hald contains a file descriptor leak that makes normal users unable to
eject audio CDs and other CDs/DVDs that does not contain normal
filesystems.

Problem identified and fixed by Peter Österlund, originally posted on
LKML.


Regards: David Weinehall

--- hal-0.4.2/hald/linux/block_class_device.c.old	2004-12-29 23:51:17.200288832 +0100
+++ hal-0.4.2/hald/linux/block_class_device.c	2004-12-29 23:51:23.040401000 +0100
@@ -1055,6 +1055,7 @@
 				if (is_cdrom) {
 					/* volume_id cannot probe blank/audio discs etc,
 					 * so don't fail for them, just set vid to NULL */
+					volume_id_close (vid);
 					vid = NULL;
 				} else {
 					g_object_unref (child);




----- End forwarded message -----

-- 
The instruments of science do not in themselves discover truth.  And there are
searchings that are not concluded by the coincidence of a pointer and a mark.
		-- Fred Saberhagen, "The Berserker Wars"
_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal