[patch] Also handle the case that recover_net_device fails

Sjoerd Simons sjoerd at luon.net
Tue Jan 4 13:08:57 PST 2005


Hi,

  Hal doesn't handle the case that recover_net_device fails, causing a nice 
  segv. Fixed in attached patch.
  
  Sjoerd
-- 
The true way goes over a rope which is not stretched at any great height
but just above the ground.  It seems more designed to make people stumble
than to be walked upon.
		-- Franz Kafka
-------------- next part --------------
Index: hald/linux/osspec.c
===================================================================
RCS file: /cvs/hal/hal/hald/linux/osspec.c,v
retrieving revision 1.52.2.2
diff -u -r1.52.2.2 osspec.c
--- hald/linux/osspec.c	1 Dec 2004 04:28:58 -0000	1.52.2.2
+++ hald/linux/osspec.c	4 Jan 2005 20:54:28 -0000
@@ -1037,8 +1037,10 @@
 						} else {
 							HAL_INFO (("%s worked!", sysfs_path));
 						}
+					} else {
+						HAL_INFO (("Recovery failed!"));
+						return NULL;
 					}
-
 				} else {
 					HAL_WARNING (("Coulnd't get sysfs class device object at path %s", sysfs_path));
 					return NULL;
-------------- next part --------------
_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal


More information about the Hal mailing list