hal 0.4.5 "It's going to go 100% failure in 72 hours." releas ed

[Kay Sievers]

On Mon, 2005-01-17 at 14:52 +0100, Schupp Roderich (extern) Com MD PD
SWP 2 CM MCH wrote:
> >   I just upgraded hal (from 0.4.4-1) and noticed, that it 
> > doesn't detect
> >   the volume label of my usb external drive correctly anymore. I found
> >   this bug, and this change seems to be the cause...
> > 
> >   Both mlabel and udev_volume_id show the correct label 
> > ("ICYBOX"), but
> >   hal uses "AD", which is pretty useless...
> 
> The problem are VFAT extended entries in the root directory.
> The one-line change from 0.4.4 will erroneously take the
> first extended entry for the volume id.
> These extented entries are recognizable by attr = 0x0f
> (i.e. readonly + system + hidden + volume_id).
> 
> I think there's also an off-by-one error in iterating over
> the directory entries. 

Thanks a lot! I've applied it to CVS.

Thanks,
Kay

_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal