ACPI/PMU procfs HAL test program. Version 003.

[Richard Hughes]

On Thu, 27 Jan 2005 00:58:46 +0200, Paul Ionescu wrote:
> Here is another patch for procfs_acpi v3:

Cool. Now we have to update the spec on HEAD accordingly... it keeps
changing!
 
> +
> +       /* add string [system.battery.type = laptop] */ +
> hal_device_property_set_string(d, "system.battery.type", "laptop");

Okay.

> -               /* add string [system.battery.type] */ -              
> if ( procfs_getvalue(listbuffer, "battery type", buffer) ) -            
>           hal_device_property_set_string(d, "system.battery.type",
> buffer); +               /* add string [system.battery.techonolgy] */ + 
>              if ( procfs_getvalue(listbuffer, "battery technology",
> buffer) ) +                       hal_device_property_set_string(d,
> "system.battery.technology", buffer);

Don't you want?:
if ( procfs_getvalue(listbuffer, "battery type", buffer) )
	hal_device_property_set_string(d, "system.battery.technology", buffer);

> -               /* add string [system.battery.rechargeable.is_charging]
> */ -               if ( procfs_getbool(listbuffer, "charging state",
> "charging", &value) ) -                      
> hal_device_property_set_bool(d,
> "system.battery.rechargeable.is_charging", value); +               /*
> add string [system.battery.rechargeable.charging_state] */ +            
>   if ( procfs_getvalue(listbuffer, "charging state", buffer) ) +        
>               hal_device_property_set_string(d,
> "system.battery.rechargeable.charging_state", buffer);

Cool, thanks.

Richard.

-- 

http://www.hughsie.com/PUBLIC-KEY


_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal