[PATCH] Add strlist support to hal-set-property for LUKS

[David Zeuthen]

On Mon, 2005-07-25 at 22:44 -0500, W. Michael Petullo wrote:
> This patch makes the following changes:
> 
> 1.  Add --strlist-pre, --strlist-post and --strlist-rem options to hal-set-property.

Nice.

> 
> 2.  hal-luks-setup now uses hal-set-property to add hal-luks-remove to
> a LUKS device's info.callouts.remove.
> 
> 3.  Add a hal-luks-remove script.

Also nice. Does it work well? (haven't tested it yet)

> 
> 4.  Modify configure to look for luks-setup and cryptsetup to ensure
> the paths are correct in hal-luks-setup and hal-luks-remove.

This would require a BuildRequires: cryptsetup-luks when building on
Fedora and I don't really like that :-). I think we should just assume
that the hal and cryptsetup-luks are built in the same prefix.

> 
> The patch is against hal CVS as of 25 July 2005.

Patch looks good if you can redo the configure.in pieces.

Cheers,
David


_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal