Feature requests for hal battery backend.

[David Zeuthen]

Hi,

Sorry for jumping a bit late into the thread =)

On Sat, 2005-07-30 at 23:57 +0100, Richard Hughes wrote:
> On Sat, 2005-07-30 at 17:32 -0400, Ryan Lortie wrote:
> > I give it eleven thumbs up.
> 
> Freak. :-)
> 
> New patch attached. I'm sure there are errors, I've been up hours!

Some small details

+       const char *path, *reporting_unit;
+       int reporting_current, reporting_lastfull, reporting_rate;

One line per variable declaration please.

+                       int reporting_design, voltage_design;
+                       const char *reporting_unit;

Need to at start of block, cannot assume C99.

The larger design and thoughts about this are fine I think. Just to be
clear, we want to standardize on mWh right? What about patches for APM
and PMU (I can test the PMU bits on my Powerbook)? =)

I think Danny had some more comments elsewhere in this thread; maybe you
can send the updated patch in a new thread? (and please keep desrt on
the Cc). Much thanks.

Cheers,
David





_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal