[patch] addon-hid-ups.c : battery.present is mandatory for HAL spec

Richard Hughes hughsient at gmail.com
Mon May 9 12:14:38 PDT 2005


On Mon, 2005-05-09 at 15:09 -0400, David Zeuthen wrote:
> On Mon, 2005-05-09 at 19:42 +0100, Richard Hughes wrote:
> > On Mon, 2005-05-09 at 17:28 +0100, Richard Hughes wrote:
> > <snip>
> > > I'll work on a patch.
> > 
> > Attached, I know it's quick and dirty, but I wanted comments. 
> 
> Propose to make a generic function in hald/util.c and use it for both
> APM, PMU and ACPI.

No can do, for two reasons (unless I'm wrong:-):

* APM / PMU / UPS already provide hardware-generated remaining_time
values
* APM / PMU do not provide charge/discharge rate values

> > How
> > expensive is setting an int as a property, then getting it? 
> 
> Only rule is to not set it multiple times as each time setting it will
> emit a notification.

That's what I thought.

Thanks, Richard.

_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal



More information about the Hal mailing list