[PATCH] lshal - The next generation

Richard Hughes hughsient at gmail.com
Sat Nov 5 05:41:50 PST 2005


(sorry for the delay...)

In:
static void usage (int argc, char *argv[])

Why are we printing to stderr? We appear to be using stderr to output
all the screen output, which I appreciate the original lshal did. Should
this not be stdout?

Also, should the version check not be done with "-v" rather than "-V"?

print_props() and print_property() are very similar, can we not share
the common code in another function?

Some lines are very long, and should probably be split.

I'm going thru the patch bit by bit at the moment. Do you want to do the
corrections now, or I could apply the patch as is, and we can work from
CVS to do the corrections.

Richard.




More information about the hal mailing list